[PATCH] D135518: [clangAST] support TypeLoc in TextNodeDumper

Tobias Ribizel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 14 00:20:39 PDT 2022


upsj added inline comments.


================
Comment at: clang/include/clang/AST/TextNodeDumper.h:337
+  void VisitConstantArrayTypeLoc(ConstantArrayTypeLoc TL);
+  void VisitVariableArrayTypeLoc(VariableArrayTypeLoc TL);
+  void VisitDependentSizedArrayTypeLoc(DependentSizedArrayTypeLoc TL);
----------------
aaron.ballman wrote:
> Should you also handle `IncompleteArrayTypeLoc` as well?
Not sure about this one, since it has no additional metadata - the type location visitor already prints out the type class name


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135518/new/

https://reviews.llvm.org/D135518



More information about the cfe-commits mailing list