[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 13 19:29:25 PDT 2022


beanz added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DXILResource.h:46
   // can only be added to the end, and not removed.
   enum class Kinds : uint32_t {
     Invalid = 0,
----------------
python3kgae wrote:
> Could we move ResourceBase::Kinds to Frontend/HLSL/HLSLResource.h so we can share it between clang and llvm?
Within reason, we can move any code that makes sense to share. We should do that in changes where the moved code will be used rather than making this change larger.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135110/new/

https://reviews.llvm.org/D135110



More information about the cfe-commits mailing list