[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

[ChenZheng via Phabricator via cfe-commits]

shchenz added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:589
+      // On platforms other than AIX, gdb is the default option.
+      // On AIX, dbx will be automatically pick up in the presense of the
+      // debugger tuning argument, so set gdb only if it is specified.
----------------
Typo: presense -> absence?


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:590
+      // On AIX, dbx will be automatically pick up in the presense of the
+      // debugger tuning argument, so set gdb only if it is specified.
+      if (!IsOSAIX || A->getOption().matches(options::OPT_ggdb) ||
----------------
Could you also post another patch to fix the no-lto path to remove the redundant `-debugger-tuning=dbx` on AIX? We should make the lto mode and non-lto mode be consistent.


================
Comment at: clang/test/Driver/lto-aix.c:8
+//
+// Test debugging options
+// RUN: %clang -target powerpc-ibm-aix-xcoff -### %s -flto -g 2>&1 \
----------------
Can we add case that by default, no `-debugger-tune` is emitted?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135908/new/

https://reviews.llvm.org/D135908