[PATCH] D133753: [clang][Interp] WIP: Array fillers

[Shafik Yaghmour via Phabricator via cfe-commits]

shafik added inline comments.


================
Comment at: clang/lib/AST/Interp/Descriptor.h:83
+  ///   that have an array filler.
+  const InterpSize NumFullElems = 0;
+  const Expr *ArrayFiller = nullptr;
----------------
How about `NumElemsWithFiller`? 


================
Comment at: clang/lib/AST/Interp/Pointer.h:252
+    const Descriptor *Desc = getFieldDesc();
+    // The given index should never be greater than NumFullElems,
+    // this needs to be checked earlier.
----------------
You say `greater` here but you use `<` below in the assert instead of `<=`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133753/new/

https://reviews.llvm.org/D133753