[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

Thu Oct 13 16:31:10 PDT 2022

jdoerfert added a comment.

This now looks good. The test is the only things I don't understand.

================
Comment at: clang/test/OpenMP/irbuilder_simd_aligned.cpp:69
+// CHECK:       omp_loop.preheader:
+// CHECK-COUNT-3: call void @llvm.assume(i1 true) [ "align"
+// CHECK-NEXT:    br label [[OMP_LOOP_HEADER:%.*]]
----------------
Did you not check the alignment here on purpose? I'd assume this is the most important line in the test, no? Also, consider this cannot be auto-updated anymore w/o loosing manual updates.

================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:631
+                 Value *IfCond, omp::OrderKind Order, ConstantInt *Simdlen,
+                 ConstantInt *Safelen);

----------------
No llvm::

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133578/new/

https://reviews.llvm.org/D133578