[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

Alan Zhao via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 13 15:41:11 PDT 2022


ayzhao added inline comments.


================
Comment at: clang/lib/AST/ExprConstant.cpp:15717
+    // FIXME: unimplemented
+    llvm_unreachable("unimplemented");
   }
----------------
0x59616e wrote:
> cor3ntin wrote:
> > This is fairly important, ie you should make sure the feature works in constexpr contextes
> I just let it fall through to the 'NotICE' path.
FYI `constexpr` is now implemented and tested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129531/new/

https://reviews.llvm.org/D129531



More information about the cfe-commits mailing list