[PATCH] D135326: Half-done attempt to move tail padding callback from TargetCXXABI to TargetInfo

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 13 15:03:56 PDT 2022


dblaikie added a comment.

In D135326#3854141 <https://reviews.llvm.org/D135326#3854141>, @rjmccall wrote:

> I don't remember the history of the `-fc++-abi` flag at all, so if that's a driver flag, you'll probably need to investigate it more to remove it.  Maybe it was added for testing purposes and only made a driver flag accidentally.

Ah, fair enough. Looks like this got added relatively recently (I mean, still a couple of years ago in 2020) in https://reviews.llvm.org/D85802
Guess we had one ABI flag for this added in rG95a546ee4dbdc997e9898c9839f3851f46a78b5c <https://reviews.llvm.org/rG95a546ee4dbdc997e9898c9839f3851f46a78b5c>, removed in rGc9bd88e6811fb622cde644a82eac41c0b02c00ee <https://reviews.llvm.org/rGc9bd88e6811fb622cde644a82eac41c0b02c00ee> and then the new one added in the above review.
Ah well, all very confusing.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135326/new/

https://reviews.llvm.org/D135326



More information about the cfe-commits mailing list