[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 13 13:20:58 PDT 2022


shafik added inline comments.


================
Comment at: clang/lib/Sema/SemaExpr.cpp:6785
+    //   other than to declare it, is ill-formed. [...]
+//    if (CheckReferencedFunctionTrailingRequiresClause(FD, ConstraintFailLoc))
+//      return ExprError();
----------------
This code is commented out, did you mean to remove it? Since this is the only code using `ConstraintFailLoc ` then that should go to if you delete this code.


================
Comment at: clang/test/SemaTemplate/concepts.cpp:712
+// These should not diagnose, where we were unintentionally doing so before by
+// checking these two times, yet not having the ability to the 2nd time, since
+// it was no longer a dependent variant.
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135772/new/

https://reviews.llvm.org/D135772



More information about the cfe-commits mailing list