[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

Thu Oct 13 10:07:53 PDT 2022

hans added a comment.

Heads up that we're seeing a problem in Chromium that bisects to this change. (http://crbug.com/1373836)

In our case what's happening is that the compiler is getting the name of an included file wrong, which ends up in the debug info (and also shows in the preprocessor output). What makes it interesting is that this only reproduces on a remote build system, not when building locally.

I see there's discussion about symlinks of identical files, and I just realized that in our case the files are indeed identical. I haven't heard back from the build system folks, but I wouldn't be surprised if they symlink these against some content-addressed storage system.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135220/new/

https://reviews.llvm.org/D135220