[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Thu Oct 13 06:48:55 PDT 2022

erichkeane added a comment.

In D126907#3855552 <https://reviews.llvm.org/D126907#3855552>, @erichkeane wrote:

> In D126907#3854983 <https://reviews.llvm.org/D126907#3854983>, @cor3ntin wrote:
>
>> @erichkeane I was looking at Daisy meta programming shenanigans and found this crashes https://cute.godbolt.org/z/6fWoEheKc - seems related to your work, probably? It used to work in Clang 15. I thought you might want to know!
>
> Thanks!  I'll take a look.  That DOES look like some other failures I've had with this patch.

I've reduced it a bit to remove the STL stuff, but it looks like the template-lambda is a part of it: https://cute.godbolt.org/z/Prh6xsesz

It manages to hit quite a few things that I suspect the `getTemplateInstantiationArgs` doesn't get right, so I'm guessing the 'fix' is going to be in there somewhere.  I'll start taking a look this week.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126907/new/

https://reviews.llvm.org/D126907