[PATCH] D135796: [HIP] Detect HIP for Debian/Fedora

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:309
 
+  ROCmSearchDirs.emplace_back(D.SysRoot + "/usr/local",
+                              /*StrictChecking=*/true);
----------------
tra wrote:
> yaxunl wrote:
> > tra wrote:
> > > Should it be done for Debian/Fedora only? See clang/include/clang/Driver/Distro.h for `IsDebian/IsRedhat()` helpers.
> > I think other Linux distributions may adopt it too, since /usr is the standard location.
> Or they may do something completely different. I've been surprised in the past by how NVIDIA packages get split in different ways on different distributions.
> 
> I'm fine with using established locations where we do have them, but I'm reluctant to add something open-ended that we do not need and which may be hard to change later. Expanding the scope of the search if/when we need it somewhere is easy, removing things that users may have grown to depend on is often hard.
Makes sense. will do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135796/new/

https://reviews.llvm.org/D135796