[PATCH] D135060: [HLSL] Add groupshare address space.

[Chris Bieneman via Phabricator via cfe-commits]

beanz added inline comments.


================
Comment at: clang/include/clang/Basic/Attr.td:4063
+  let Spellings = [Keyword<"groupshared">];
+  let Documentation = [HLSLGroupSharedAddressSpaceDocs];
+}
----------------
Shouldn't this have `let Subjects = SubjectList<[Var]>;`?

I don't think we support `groupshared` on anything except variable declarations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135060/new/

https://reviews.llvm.org/D135060