[PATCH] D135796: [HIP] Detect HIP for Debian/Fedora

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 12 11:04:21 PDT 2022


yaxunl added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:309
 
+  ROCmSearchDirs.emplace_back(D.SysRoot + "/usr/local",
+                              /*StrictChecking=*/true);
----------------
tra wrote:
> Should it be done for Debian/Fedora only? See clang/include/clang/Driver/Distro.h for `IsDebian/IsRedhat()` helpers.
I think other Linux distributions may adopt it too, since /usr is the standard location.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135796/new/

https://reviews.llvm.org/D135796



More information about the cfe-commits mailing list