[PATCH] D135724: [HIP] Fix unbundling archive

[Artem Belevich via Phabricator via cfe-commits]

tra added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1839
   auto Ext = IsMSVC ? ".lib" : ".a";
-  if (!Lib.startswith(":") && llvm::sys::fs::exists(Lib)) {
-    ArchiveOfBundles = Lib;
-    FoundAOB = true;
+  if (!Lib.startswith(":") && !Lib.startswith("-l")) {
+    if (llvm::sys::fs::exists(Lib)) {
----------------
I'm puzzled a bit. What is expected to be in 'Lib' ?
If it contains the the whole `-llibrary` option passed by the user, then why do we check for `:` prefix?
If it contains whatever was passed via `-l<something>`, but without `-l` itself, then why do we check for  `-l` prefix?



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135724/new/

https://reviews.llvm.org/D135724