[PATCH] D135712: [CMake] Fix FindGRPC cmake module to allow different layering

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 12 10:01:13 PDT 2022


sammccall added a comment.

Hmm, as mentioned on the bug, I think wrapping the deps and generated sources into a library is an important part of what the build rule does.

If we need to split it up like this, I think a `generate_clang_protos` wrapper in FindGRPC.cmake might be the right place to encapsulate it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135712/new/

https://reviews.llvm.org/D135712



More information about the cfe-commits mailing list