[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 12 09:06:01 PDT 2022


erichkeane added a subscriber: Uthkarsh.
erichkeane added a comment.

In D126907#3852975 <https://reviews.llvm.org/D126907#3852975>, @BertalanD wrote:

> (I know this is a very contrived example with `void operator!=`, but that is what CVise spat out, and the actual failures are related to comparison operators too)
>
> edit: hah, it repros when it returns `bool` too -- not sure how that `void` came to be...

Looking more closely at that, I don't think it has anything to do with this patch.  I know `operator==` (and the materialized inverse) stuff was worked on separately recently by @Uthkarsh in 38b9d313e6945804fffc654f849cfa05ba2c713d <https://reviews.llvm.org/rG38b9d313e6945804fffc654f849cfa05ba2c713d>.  See: https://reviews.llvm.org/D134529

The Equality-operator stuff has been particularly awkward in the C++ committee I think (whether or not reversed candidates work or not have had a bunch of tweaking), so you'll have to follow that up there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126907/new/

https://reviews.llvm.org/D126907



More information about the cfe-commits mailing list