[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 12 08:54:05 PDT 2022


erichkeane added a comment.

In D126907#3852909 <https://reviews.llvm.org/D126907#3852909>, @BertalanD wrote:

> I tried out D135772 <https://reviews.llvm.org/D135772>, and our build got significantly farther than before! I unfortunately discovered another piece of code that pre babdef27c503c0bbbcc017e9f88affddda90ea4e <https://reviews.llvm.org/rGbabdef27c503c0bbbcc017e9f88affddda90ea4e> Clang and GCC accept in C++20 mode, but Clang trunk does not (https://godbolt.org/z/q1q4nfobK):
>
>   struct String {
>     String(char *);
>     bool operator==(String const &);
>     void operator!=(String const &);
>   };
>   
>   extern char* c;
>   extern String s;
>   int test() {
>     return c == s;
>   }
>
>
>
>   <source>:10:12: error: invalid operands to binary expression ('char *' and 'String')
>     return c == s;
>            ~ ^  ~

Thanks!  I'll look into that as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126907/new/

https://reviews.llvm.org/D126907



More information about the cfe-commits mailing list