[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

Wed Oct 12 03:11:36 PDT 2022

boris added a comment.

> For example, my experimental support for P1689 <https://reviews.llvm.org/P1689> is at: [...]. The implementation looks relatively trivial to me. The simplicity is pretty important.

Two points:

1. It's worth considering the simplicity of the overall system (compiler + build system + user project) rather than just the compiler. I hope my previous comment highlighted some of the complexity that the overall system must deal with in the pre-scan approach with a lot of it potentially ending up on the user's plate.

2. I haven't looked at the code, but there are some complex problems in this area as highlighted by this MSVC bug: https://developercommunity.visualstudio.com/t/scanDependencies-does-not-take-into-acc/10029154 I believe you may have it easier because reportedly Richard & friends have already implemented the necessary header import isolation semantics.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134267/new/

https://reviews.llvm.org/D134267