[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

[serge via Phabricator via cfe-commits]

serge-sans-paille added inline comments.


================
Comment at: clang/lib/AST/Expr.cpp:228
+    if (StrictFlexArraysLevel == FAMKind::OneZeroOrIncomplete && Size.uge(2))
+      return false;
   } else if (!Context.getAsIncompleteArrayType(getType()))
----------------
I <3 this simplification! This is definitively going to introduce regression, but if this aligns with GCC behavior I think it's okay.
I don't see how it's related to union though. Could you explain?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135727/new/

https://reviews.llvm.org/D135727