[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline
Ziqing Luo via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 11 15:22:07 PDT 2022
ziqingluo-90 added reviewers: aaron.ballman, njames93, t-rasmud.
ziqingluo-90 added inline comments.
================
Comment at: clang/include/clang/ASTMatchers/ASTMatchersMacros.h:96
namespace internal { \
- class matcher_##DefineMatcher##Matcher \
+ class matcher_##DefineMatcher##Matcher final \
: public ::clang::ast_matchers::internal::MatcherInterface<Type> { \
----------------
I was wondering if this change is necessary. This definition is so general that it could affect a massive matchers. So any change to it should be very careful and unnecessary changes may be avoided.
Other than that, this patch looks good to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135690/new/
https://reviews.llvm.org/D135690
More information about the cfe-commits
mailing list