[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added a comment.

In D130096#3850708 <https://reviews.llvm.org/D130096#3850708>, @b-sumner wrote:

>> Different functions providing different behaviors can be handled at link time like any other function, instead of the same functions providing different behaviors per translation unit and requires cloning. The current scheme transfers complexity from the device library build system into the driver and user binaries
>
> OK, but we are talking about trading a solved problem with a solution working for years for adding a large amount of new work and new maintenance and new bugs.  Does this need to be done now, or at all?

I wouldn't really call it a solved problem when only one of the many users is currently linking these libraries correctly


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130096/new/

https://reviews.llvm.org/D130096