[PATCH] D135715: [Clang] Do not build the OffloadActionBuilder when using the new driver

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 11 14:33:48 PDT 2022


tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Driver/Driver.cpp:3987-3988
     // required.
     if (!UseNewOffloadingDriver)
-      if (OffloadBuilder.addHostDependenceToDeviceActions(Current, InputArg))
+      if (OffloadBuilder->addHostDependenceToDeviceActions(Current, InputArg))
         break;
----------------
Nit: Having to prefix every use of `OffloadBuilder` looks a bit cumbersome.

It would look a bit cleaner if we had some sort of no-op builder we'd populate OffloadBuilder with. Does not buy us anything functionally, though, so it may not be worth complicating things just for this. Up to you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135715/new/

https://reviews.llvm.org/D135715



More information about the cfe-commits mailing list