[PATCH] D129156: Add -fpass-plugin option to Flang

[Andrzej Warzynski via Phabricator via cfe-commits]

awarzynski added a comment.

In @clementval 's CMake invocation `LLVM_BUILD_EXAMPLES` is not set, which means that the examples (e.g. the `Bye` plugin) are not built. Adding  `! REQUIRES: examples` to the test should fix the failure in this case. I did verify locally.

However, the pre-commit CI that was failing did include the examples:

  cmake ../llvm -D LLVM_ENABLE_PROJECTS="mlir;flang;clang;llvm" -G Ninja -D CMAKE_BUILD_TYPE=Release -D LLVM_ENABLE_ASSERTIONS=ON -D LLVM_BUILD_EXAMPLES=ON -D LLVM_LIT_ARGS="-v --xunit-xml-output test-results.xml" -D LLVM_ENABLE_LLD=ON -D CMAKE_CXX_FLAGS=-gmlt -DBOLT_CLANG_EXE=/usr/bin/clang

You can see there <https://buildkite.com/llvm-project/premerge-checks/builds/115370> that `libBye.so` is not built. Could you try that command, pls?

In D129156#3849487 <https://reviews.llvm.org/D129156#3849487>, @tarunprabhu wrote:

> I imagine that we want the feature to be tested even when building flang out-of-tree.

I don't built standalone LLVM Flang, so won't be needing it. Perhaps somebody else will, dunno :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129156/new/

https://reviews.llvm.org/D129156