[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

YingChi Long via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 11 11:24:10 PDT 2022


inclyc added a comment.

This makes sense! However I think `assert(0)` should not be used in this case, we could expose another `llvm_unreachable`-like api and probably `llvm_report_error` shall be fine. Are there some changed assertions actually "Aspirationally unreachable" in this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135551/new/

https://reviews.llvm.org/D135551



More information about the cfe-commits mailing list