[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

[Yuanfang Chen via Phabricator via cfe-commits]

ychen added a comment.

Looks good to me except for one nit. And the test still fails on Windows for some reason.



================
Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1612
+      time_t TT = *getPreprocessorOpts().SourceDateEpoch;
+      std::tm *TM = std::gmtime(&TT);
       Result = asctime(TM);
----------------
To be consistent with existing code, it might be better to use `std::localtime` instead of `std::gmtime`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135045/new/

https://reviews.llvm.org/D135045