[PATCH] D129156: Add -fpass-plugin option to Flang

[Andrzej Warzynski via Phabricator via cfe-commits]

awarzynski added a comment.

In D129156#3848704 <https://reviews.llvm.org/D129156#3848704>, @clementval wrote:

>>> I still cannot reproduce the build failure on my end. @MatsPetersson tested this patch and the tests passed.
>>
>> @MatsPetersson & @clementval , could you share you build command so that the failure can be reproduced before this re-lands?
>
> I shared it with @tarunprabhu and I think the only major difference is the use of Ninja vs. Unix Makefiles.
>
>   cmake \
>     -G "Unix Makefiles" \
>     -DCMAKE_BUILD_TYPE=Release \
>     -DLLVM_ENABLE_ASSERTIONS=ON \
>     -DLLVM_TARGETS_TO_BUILD=host \
>     -DLLVM_ENABLE_PROJECTS="clang;mlir;flang" \
>     -DLLVM_ENABLE_RUNTIMES="compiler-rt"

Thanks Valentin! Switching between generators will definitely change the order in which libraries will built (and, AFAIK, the order is non-deterministic to begin with). I will try to experiment later today.

If anyone manages to test this in the meantime, please share here - that's part of the public review process :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129156/new/

https://reviews.llvm.org/D129156