[PATCH] D135636: [clang][modules][deps] Serialize inputs into PCMs using the "as requested" name

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 10 18:42:03 PDT 2022


jansvoboda11 created this revision.
jansvoboda11 added reviewers: benlangmuir, Bigcheese.
Herald added a subscriber: ributzka.
Herald added a project: All.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

This patch changes the PCM serialization logic to refer to input files by their "requested" name. This fixes a bug where the dependency scanner reports the "final" file paths, which can result in failed explicit compiles due to the `module.modulemap` file not being surrounded by the expected framework directory structure.

Depends on D135634 <https://reviews.llvm.org/D135634>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D135636

Files:
  clang/include/clang/Serialization/ASTReader.h
  clang/lib/Frontend/FrontendAction.cpp
  clang/lib/Serialization/ASTReader.cpp
  clang/lib/Serialization/ASTWriter.cpp
  clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp
  clang/test/ClangScanDeps/modules-file-name-as-requested.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135636.466680.patch
Type: text/x-patch
Size: 7222 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221011/57656af4/attachment-0001.bin>


More information about the cfe-commits mailing list