[PATCH] D135614: [OpenMP][CUDA][AMDGPU] Accept case insensitive subarchitecture names

Mon Oct 10 13:51:59 PDT 2022

jhuber6 added a comment.

In D135614#3847775 <https://reviews.llvm.org/D135614#3847775>, @tra wrote:

> Is that really something we need/want to do? I've never seen anyone complaining about this particular issue.
>
> clang/gcc are case-sensitive for similar options, like `-march`: https://godbolt.org/z/3jKzTda7h
> I think offloading options should behave consistently in that regard. If we do want to make arch/CPU names case-agnostic, it should be done for all such options.

This came up with someone @jdoerfert worked with and I figured it was easy to implement. There is a precedent for `-march` to be case sensitive, I'm not sure if it's an issue here since it's a little arbitrary. Alternatively we could make it a warning.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135614/new/

https://reviews.llvm.org/D135614