[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

Iain Sandoe via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 10 11:18:36 PDT 2022


iains added a comment.

FAOD: I think this should not be about "who's patches" - but about the compilation model and command lines that we want to end up with.

I am concerned that with the current scheme (with or without the change in this review) we could end up with three process launches per modular file:

- one to determine the deps
- one to produce the BMI
- one to produce the object

At least with GCC (and a patch series like the one I drafted) we can reduce that to 2

With the interfaces mentioned in P1184 <https://reviews.llvm.org/P1184>, it is plausible to make that 1 (at the expense of potentially many stalled builds - but stalled early in compilation, so hopefully with the smallest memory footprint we could achieve).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134267/new/

https://reviews.llvm.org/D134267



More information about the cfe-commits mailing list