[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

YingChi Long via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 10 10:10:32 PDT 2022


inclyc added a comment.

> I've left some comments in the review about examples of my concerns (it's not an exhaustive review).

Thanks @aaron.ballman ! I didn't quite understand the original meaning of this code here (e.g. libclang), and I have now removed the relevant changes. I think this patch should replace the code that accidentally misuses of `assert(0)` with `llvm_unreachable()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135551/new/

https://reviews.llvm.org/D135551



More information about the cfe-commits mailing list