[PATCH] D135555: [libclang] CIndex: Visit UsingTypeLoc as TypeRef

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 10 07:30:54 PDT 2022


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/unittests/libclang/TestUtils.h:85
   }
+  static std::string from_CXString(CXString cx_string) {
+    std::string string{clang_getCString(cx_string)};
----------------
nit: if you're moving this function here, I think you should also rename it to either fromCXString (matches style guide) or FromCXString (matches surrounding code)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135555/new/

https://reviews.llvm.org/D135555



More information about the cfe-commits mailing list