[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 10 06:02:34 PDT 2022


erichkeane added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:397
+def err_reserved_identifier_for_future_use : Error<
+  "%0 is a compiler-reserved identifier for a future feature">;
 }
----------------
I don't think we should diagnose this for individual identifiers, I don't think this adds much value, and the identifier is already reserved for implementation use.  This implies we are going to diagnose ALL future reserved things, which we have no intention of doing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135341/new/

https://reviews.llvm.org/D135341



More information about the cfe-commits mailing list