[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 10 02:56:50 PDT 2022


ilya-biryukov added a comment.

In D134529#3845617 <https://reviews.llvm.org/D134529#3845617>, @sberg wrote:

> I just ran into newly-failing
> It looks to me like this is correctly rejected now per P2468R2.

Yes, this is intentional, the behavior of the code is the same as in C++17.

> But it is rather confusing that a note mentions the `S2` candidate, while the relevant `S1` operators `==` and `!=` are not mentioned at all.

The diagnostic is indeed not very helpful and it would be nice to improve it.
However, this is unrelated to this change, e.g. it reproduces <https://gcc.godbolt.org/z/5nGzv1bnb> in C++17 mode with Clang 10.

In D134529#3845050 <https://reviews.llvm.org/D134529#3845050>, @royjacobson wrote:

> Should cxx_status.html be updated as well? It's listed there as a C++2b paper.

@usaxena95 we have forgotten to do this indeed. Could you please update the relevant html file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134529/new/

https://reviews.llvm.org/D134529



More information about the cfe-commits mailing list