[PATCH] D135508: [clangd] Heuristic to avoid desync if editors are confused about newline-at-eof
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 10 01:33:07 PDT 2022
kadircet added a comment.
i also would rather not have the workaround solely for an editor (we usually try to address these on editor/plugin side). i am also worried about the understanding of that inferred line afterwards (e.g. what if editor thinks that line doesn't have a trailing `\n` and send edits with that view of the world, or somehow attributes the `\n` to the next line instead)
moreover, this won't fix the issue for existing clangd's (and until the next release). so i'd rather get it fixed on the client side (and if we can't, i guess editors that can't have delta changes reliably just send full text as changes).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135508/new/
https://reviews.llvm.org/D135508
More information about the cfe-commits
mailing list