[PATCH] D135542: [clangd] Rename: Allow multiple canonical declarations [1/3]

[Tom Praschan via Phabricator via cfe-commits]

tom-anders created this revision.
tom-anders added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
tom-anders updated this revision to Diff 466391.
tom-anders added a comment.
tom-anders published this revision for review.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.

clang-format


Note that locateDeclAt() now does *not* canonicalize the declaration anymore, 
since that would now lead to "AmbiguousSymbol" when there's a single declaration under the cursor that has multiple canonical declarations.
Instead, only canonicalize *after* checking how many decls we've found under the cursor.

This will allow renaming virtual methods with size_overridden_methods() > 1 in a follow-up commit.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D135542

Files:
  clang-tools-extra/clangd/refactor/Rename.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135542.466391.patch
Type: text/x-patch
Size: 15813 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221009/243193f3/attachment-0001.bin>