[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 8 13:42:49 PDT 2022


MaskRay added a comment.

In D134454#3844627 <https://reviews.llvm.org/D134454#3844627>, @zixuan-wu wrote:

> It's fine for CSKY to use config file. I only have 2 points.

Thanks. It'll be nice for CSKY to move away from changing `computeSysRoot`.

> 1. I agree sysroot should be separated from GCC because sysroot is not dependent to GCC and there is even not gcc when we use llvm runtime. This rule should also apply to multilib logic. Sysroot can detect multilib path individually.
> 2. From user view, it's not easy to add sysroot or config file path manually, so it needs good way to enable this functionality.

There is a good summary on the recent configuration file improvements: https://blogs.gentoo.org/mgorny/2022/10/07/clang-in-gentoo-now-sets-default-runtimes-via-config-file/
The proper way is to let the system GCC or a similar package to provide a Clang configuration file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134454/new/

https://reviews.llvm.org/D134454



More information about the cfe-commits mailing list