[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

Jakub Klinkovský via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 7 23:22:07 PDT 2022


lahwaacz added inline comments.


================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:963
   nextToken(/*LevelDifference=*/-AddLevels);
   HandleVerilogBlockLabel();
 
----------------
owenpan wrote:
> The `while` loop would address https://reviews.llvm.org/D135466#inline-1306331 but is optional IMO because it wouldn't distinguish `};;` and the following:
> ```
> };
> ;
> ```
Does it matter? If you have `struct foo {};;` and format it with e.g. `clang-format --style=LLVM`, you'll get
```
struct foo {};
;
```
so IMO these _should_ be indistinguishible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135466/new/

https://reviews.llvm.org/D135466



More information about the cfe-commits mailing list