[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 6 23:13:31 PDT 2022


tbaeder added inline comments.


================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:447
+    APInt Val(getIntWidth(LitType), E->getValue());
+    return this->emitConst(*T, 0, Val, E);
+  }
----------------
The `0` here is unused in `emitConst` anyway. I have a follow-up NFC patch locally to remove that parameter from `emitConst` altogether.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135366/new/

https://reviews.llvm.org/D135366



More information about the cfe-commits mailing list