[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 6 20:40:37 PDT 2022


shafik added inline comments.


================
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:2277-2278
+    if (isFriend && !QualifierLoc && !FunctionTemplate) {
+      SemaRef.FilterLookupForScope(Previous, DC, /*Scope*/ nullptr,
+                                   /*ConsiderLinkage*/ true,
+                                   QualifierLoc.hasQualifier());
----------------
Nitpick ` /*Scope=*/nullptr` and `/*ConsiderLinkage=*/true`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135370/new/

https://reviews.llvm.org/D135370



More information about the cfe-commits mailing list