[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

Thu Oct 6 13:57:14 PDT 2022

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

Test nit. LGTM otherwise.

================
Comment at: clang/test/Driver/unknown-arg.c:73
+// O-WARN-NEXT: warning: joined argument treated as '-o utput'; did you mean '--output'?
+//  O-WARN-NOT: warning: joined argument treated as '-o ffload-device-only'; did you mean '--offload-device-only'?
----------------
I think this check will never trigger, because, if the warning would happen to be issued, it would happen before the warning for ` -output` above and we'd miss it.

Doing negative test in a separate `RUN` would probably be the easiest way to deal with it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135389/new/

https://reviews.llvm.org/D135389