[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.
Xiang Li via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 6 13:54:39 PDT 2022
python3kgae added a comment.
In D133993#3840838 <https://reviews.llvm.org/D133993#3840838>, @efriedma wrote:
> It seems like it would be better to put the code in an LLVM IR transform pass, if we can. It separates the concerns more clearly, and it would make life easier for other compilers. (If you need it to run early, see registerPipelineEarlySimplificationEPCallback.)
>
> I won't block the patch on that, though.
Thanks for the review.
I like the idea to move code to LLVM IR pass.
I'll commit this PR as is, and create another one to move the code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133993/new/
https://reviews.llvm.org/D133993
More information about the cfe-commits
mailing list