[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 6 12:13:50 PDT 2022


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

It seems like it would be better to put the code in an LLVM IR transform pass, if we can. It separates the concerns more clearly, and it would make life easier for other compilers.  (If you need it to run early, see registerPipelineEarlySimplificationEPCallback.)

I won't block the patch on that, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133993/new/

https://reviews.llvm.org/D133993



More information about the cfe-commits mailing list