[PATCH] D135132: [SourceManager] Improve getFileIDLocal.

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers accepted this revision.
nickdesaulniers added inline comments.


================
Comment at: clang/lib/Basic/SourceManager.cpp:797
+  // SLocOffset.
+  unsigned LessIndex = 0;
+  // upper bound of the search range.
----------------
Consider renaming this `LesserIndex` which matches with `GreaterIndex` better.


================
Comment at: clang/lib/Basic/SourceManager.cpp:797
-      LocalSLocEntryTable[LastFileIDLookup.ID].getOffset() < SLocOffset) {
-    // Neither loc prunes our search.
-    I = LocalSLocEntryTable.end();
----------------
nickdesaulniers wrote:
> Consider renaming this `LesserIndex` which matches with `GreaterIndex` better.
So this comment was wrong?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135132/new/

https://reviews.llvm.org/D135132