[PATCH] D134942: [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation.

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 6 11:28:27 PDT 2022


nickdesaulniers accepted this revision.
nickdesaulniers added inline comments.


================
Comment at: clang/lib/Lex/TokenLexer.cpp:1019
+                          const Token &T) {
+                        return ID == SM.getFileID(T.getLocation());
+                      }) &&
----------------
Please consider moving this to

`#ifdef EXPENSIVE_CHECKS` rather than asserts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134942/new/

https://reviews.llvm.org/D134942



More information about the cfe-commits mailing list