[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 6 08:34:07 PDT 2022


erichkeane requested changes to this revision.
erichkeane added a comment.
This revision now requires changes to proceed.

In D134128#3840232 <https://reviews.llvm.org/D134128#3840232>, @lime wrote:

> I updated patch to fix the previous problem that failed to pass unit tests. And, isn't this patch accepted a little quickly? BTW, `NormalizationCache` becomes heavier than before.

Huh, woah, Phab didn't show me 1/2 this patch the last time.  The changes in Sema.h and the changes of CalculateTemplateDepthForConstraints just weren't there...

So yeah, I guess, spend more time on this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134128/new/

https://reviews.llvm.org/D134128



More information about the cfe-commits mailing list