[PATCH] D135287: Disallow dereferencing of void* in C++.

[Erich Keane via Phabricator via cfe-commits]

erichkeane marked 4 inline comments as done.
erichkeane added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6939-6942
+      // Note: This uses a different diagnostics group than the C diagnostic
+      // so that projects that have disabled the above will get this diagnostic,
+      // and be aware of the deprecation.
+      InGroup<DiagGroup<"void-ptr-dereference-cpp">>,
----------------
aaron.ballman wrote:
> Based on the code search for people using that diagnostic flag, I don't think we need to do this -- it seems like only a very small number of projects disable that warning (at least from a code search on sourcegraph). We still need a separate diagnostic (because of the `DefaultError`, but I think we can re-use the old diagnostic group. WDYT?
SGTM.  I'm not attached to it.


================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6942-6944
+      InGroup<DiagGroup<"void-ptr-dereference-cpp">>,
+      DefaultError,
+      SFINAEFailure;
----------------
aaron.ballman wrote:
> 
This is actually the result of clang-format!  I'll undo it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135287/new/

https://reviews.llvm.org/D135287