[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

Ben Langmuir via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 6 07:06:47 PDT 2022


benlangmuir added a comment.

> That change might be problematic for content addressing storages. E.g. clang/test/Driver/cl-pch-showincludes.cpp started to fail in my setup as clang/test/Driver/header{0,1,3,4}.h are all identical and can be symlinked

What is the failure you're seeing?  I would expect this change to make clang more consistent about symlinks, because it preserves which path was originally accessed.  But maybe there's an edge case somewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135220/new/

https://reviews.llvm.org/D135220



More information about the cfe-commits mailing list