[PATCH] D133647: [clang-format] Parse the else part of `#if 0`

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 6 05:08:14 PDT 2022


sammccall added a comment.

This seems to have regressed comment alignment on unrelated directives:

  #if 0
  #endif
  
  #if X
  int something_fairly_long;  // Align here please
  #endif                      // Should be aligned

These comments were aligned before this patch, but are no longer.
I'm not sure why, maybe setting the taken branch to 1 has some negative side-effect when there's no branch 1?
Filed https://github.com/llvm/llvm-project/issues/58188


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133647/new/

https://reviews.llvm.org/D133647



More information about the cfe-commits mailing list