[PATCH] D135161: [clang][Lex] Fix a crash on malformed string literals

Thu Oct 6 02:46:24 PDT 2022

cor3ntin added a comment.

In D135161#3839510 <https://reviews.llvm.org/D135161#3839510>, @kadircet wrote:

> i'll reland the fix without the test case, as it's clearly fixing one of the codepaths that'll lead to a crash. it's only the test case that's crashing, because i don't think there are certain test cases that exposed literal parser to invalid/incomplete input and i am not able to reproduce any of the crashes i've seen in buildbots locally (even under asan/msan) and because the bots don't have stack traces for whatever reason, it's impossible to chase from my side. i've pinged buildbot owners in https://discourse.llvm.org/t/buildbots-missing-stack-traces/65753 to see the issue fixed.

Makes sense. The fix is correct and if it wasn't it would affect all bots equally (I highly doubt that code path is exercised anywhere but the lex test)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135161/new/

https://reviews.llvm.org/D135161