[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

Tobias Hieta via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 6 00:42:28 PDT 2022


thieta added a comment.

This looks fine to me in principle. But I wonder if we should land the flag change first separately and make sure that no buildbots break because of it. Then we can merge the simplification a few days later when we are sure it's stabilized, since something similar happened when we upgraded to C++17 - and people already had merged code that used C++17 it was really hard to revert.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135128/new/

https://reviews.llvm.org/D135128



More information about the cfe-commits mailing list